It's neat. But there are a couple of things I'd like to see put into it. I'd like to see a redirect to /tag in the case of a single tag argument, and I'd like to see multiple tag arguments handled.
Whee. Should only be a modification to a WHERE statement in conjunction with splitting the cgi query string up in a manageable way.
So. I talked to Junior, and he pointed me at the right places to twiddle in order to get the change into the codebase.
Probably the best plan of action:
Pass "tagids" arrayref of tag ids to LJ::get_recent_items call
Whatever code path does the call to generate feeds, make it respect a "?tag=foo" GET argument? There should already be code in there that does this for other paths, model it after that?
That really should be the only changes necessary...
Hmm... where's the LiveJournal cvs archive these days? Have they switched to subversion?
I found my old install of the livejournal source on karma, so I ran cvs update.
Looks like Mark's got his hands all over cgi-bin/Apache/LiveJournal.pm
Take a break man! it's Sunday :) You must like this coding stuff as much as I do.
Also, this means I should set up a LiveJournal test server, I would assume. If I want to test it before I check it in, that is.
Does this mean I have to fill up the database on the system, too? Maybe I'll write a script that regresses it. Whee. Mark, what does your regression framework look like?